Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Exception Replay] Fixed capturing issue of async methods with await in finally block + added missing snapshot attributes + better frame matching algorithm #6549

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

[Exception Replay] Fixed capturing issue of async methods with await in finally block + added missing snapshot attributes + better frame matching algorithm #6549

wants to merge 2 commits into from

Conversation

GreenMatan
Copy link
Contributor

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

@GreenMatan GreenMatan force-pushed the matang/exception-replay-capturing-improvements branch 2 times, most recently from d56089b to a3a217d Compare January 15, 2025 13:23
@GreenMatan
Improved Exception Replay frame matching algorithm + capturing except…
fa2c06d 
…ions that have duplicated frames due to await in finally blocks + added missing attributes to snapshot (exceptionHash, exceptionId, frameIndex)
@GreenMatan GreenMatan force-pushed the matang/exception-replay-capturing-improvements branch from a3a217d to fa2c06d Compare January 15, 2025 13:24
@GreenMatan GreenMatan changed the title [Exception Replay] Better capturing async methods with await in finally block + added missing snapshot attributes + better frame matching algorithm [Exception Replay] Fixed capturing issue of async methods with await in finally block + added missing snapshot attributes + better frame matching algorithm Jan 15, 2025
@andrewlock
Copy link
Member

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6549) - mean (69ms)  : 65, 73
     .   : milestone, 69,
    master - mean (68ms)  : 66, 71
     .   : milestone, 68,

    section CallTarget+Inlining+NGEN
    This PR (6549) - mean (981ms)  : 955, 1006
     .   : milestone, 981,
    master - mean (979ms)  : 952, 1005
     .   : milestone, 979,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6549) - mean (107ms)  : 105, 109
     .   : milestone, 107,
    master - mean (107ms)  : 104, 110
     .   : milestone, 107,

    section CallTarget+Inlining+NGEN
    This PR (6549) - mean (679ms)  : 661, 696
     .   : milestone, 679,
    master - mean (677ms)  : 660, 694
     .   : milestone, 677,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6549) - mean (91ms)  : 88, 93
     .   : milestone, 91,
    master - mean (91ms)  : 88, 93
     .   : milestone, 91,

    section CallTarget+Inlining+NGEN
    This PR (6549) - mean (635ms)  : 621, 650
     .   : milestone, 635,
    master - mean (633ms)  : 615, 652
     .   : milestone, 633,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6549) - mean (190ms)  : 186, 194
     .   : milestone, 190,
    master - mean (193ms)  : 189, 197
     .   : milestone, 193,

    section CallTarget+Inlining+NGEN
    This PR (6549) - mean (1,088ms)  : 1055, 1121
     .   : milestone, 1088,
    master - mean (1,097ms)  : 1065, 1130
     .   : milestone, 1097,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6549) - mean (274ms)  : 269, 279
     .   : milestone, 274,
    master - mean (278ms)  : 272, 284
     .   : milestone, 278,

    section CallTarget+Inlining+NGEN
    This PR (6549) - mean (863ms)  : 836, 891
     .   : milestone, 863,
    master - mean (870ms)  : 846, 893
     .   : milestone, 870,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6549) - mean (264ms)  : 259, 270
     .   : milestone, 264,
    master - mean (267ms)  : 263, 271
     .   : milestone, 267,

    section CallTarget+Inlining+NGEN
    This PR (6549) - mean (846ms)  : 814, 878
     .   : milestone, 846,
    master - mean (851ms)  : 818, 883
     .   : milestone, 851,
Loading

@andrewlock
Copy link
Member

Benchmarks Report for tracer 🐌

Benchmarks for #6549 compared to master:

  • 1 benchmarks are faster, with geometric mean 1.133
  • 1 benchmarks have fewer allocations
  • 1 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 8.31μs 47.1ns 319ns 0.0153 0.00764 0 5.61 KB
master StartStopWithChild netcoreapp3.1 10.4μs 52.4ns 251ns 0.0204 0.0102 0 5.79 KB
master StartStopWithChild net472 16.4μs 64.4ns 250ns 1.05 0.331 0.107 6.2 KB
#6549 StartStopWithChild net6.0 8.14μs 45.9ns 298ns 0.0166 0.00828 0 5.61 KB
#6549 StartStopWithChild netcoreapp3.1 10.2μs 56.8ns 355ns 0.025 0.00998 0 5.8 KB
#6549 StartStopWithChild net472 16.1μs 60.2ns 233ns 1.04 0.303 0.0981 6.21 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 485μs 361ns 1.35μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 671μs 509ns 1.97μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 876μs 417ns 1.61μs 0.428 0 0 3.3 KB
#6549 WriteAndFlushEnrichedTraces net6.0 487μs 435ns 1.68μs 0 0 0 2.7 KB
#6549 WriteAndFlushEnrichedTraces netcoreapp3.1 654μs 427ns 1.6μs 0 0 0 2.7 KB
#6549 WriteAndFlushEnrichedTraces net472 870μs 770ns 2.98μs 0.431 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 153μs 880ns 7.1μs 0.158 0 0 14.47 KB
master SendRequest netcoreapp3.1 181μs 1.42μs 14.1μs 0.166 0 0 17.27 KB
master SendRequest net472 0.00445ns 0.00132ns 0.00512ns 0 0 0 0 b
#6549 SendRequest net6.0 155μs 960ns 9.41μs 0.145 0 0 14.47 KB
#6549 SendRequest netcoreapp3.1 171μs 978ns 7.83μs 0.166 0 0 17.27 KB
#6549 SendRequest net472 0.000521ns 0.000301ns 0.00112ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #6549

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1 41.63 KB 41.87 KB 240 B 0.58%

Fewer allocations 🎉 in #6549

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0 41.78 KB 41.52 KB -265 B -0.63%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 592μs 3.11μs 14.9μs 0.573 0 0 41.78 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 700μs 3.13μs 16.5μs 0.363 0 0 41.63 KB
master WriteAndFlushEnrichedTraces net472 843μs 3.19μs 12.4μs 8.33 2.5 0.417 53.32 KB
#6549 WriteAndFlushEnrichedTraces net6.0 549μs 2.79μs 15μs 0.563 0 0 41.52 KB
#6549 WriteAndFlushEnrichedTraces netcoreapp3.1 670μs 3.26μs 13.8μs 0.353 0 0 41.87 KB
#6549 WriteAndFlushEnrichedTraces net472 849μs 3.89μs 15.5μs 8.08 2.55 0.425 53.27 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.25μs 1.66ns 6.44ns 0.014 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 1.78μs 2.15ns 8.34ns 0.0134 0 0 1.02 KB
master ExecuteNonQuery net472 2.11μs 2.21ns 8.57ns 0.157 0.00106 0 987 B
#6549 ExecuteNonQuery net6.0 1.24μs 1.29ns 4.82ns 0.0144 0 0 1.02 KB
#6549 ExecuteNonQuery netcoreapp3.1 1.73μs 1.75ns 6.79ns 0.0132 0 0 1.02 KB
#6549 ExecuteNonQuery net472 2.01μs 3.06ns 11.9ns 0.156 0.00101 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.27μs 0.452ns 1.69ns 0.0133 0 0 976 B
master CallElasticsearch netcoreapp3.1 1.69μs 0.738ns 2.86ns 0.0124 0 0 976 B
master CallElasticsearch net472 2.64μs 1.52ns 5.88ns 0.158 0 0 995 B
master CallElasticsearchAsync net6.0 1.25μs 0.542ns 2.1ns 0.0136 0 0 952 B
master CallElasticsearchAsync netcoreapp3.1 1.64μs 0.715ns 2.67ns 0.0139 0 0 1.02 KB
master CallElasticsearchAsync net472 2.59μs 1.32ns 4.94ns 0.167 0 0 1.05 KB
#6549 CallElasticsearch net6.0 1.26μs 0.852ns 3.3ns 0.0139 0 0 976 B
#6549 CallElasticsearch netcoreapp3.1 1.57μs 1.31ns 4.9ns 0.0134 0 0 976 B
#6549 CallElasticsearch net472 2.6μs 2.07ns 8.02ns 0.158 0 0 995 B
#6549 CallElasticsearchAsync net6.0 1.28μs 0.654ns 2.53ns 0.0134 0 0 952 B
#6549 CallElasticsearchAsync netcoreapp3.1 1.65μs 0.995ns 3.85ns 0.014 0 0 1.02 KB
#6549 CallElasticsearchAsync net472 2.63μs 1.75ns 6.79ns 0.166 0 0 1.05 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.25μs 0.934ns 3.5ns 0.013 0 0 952 B
master ExecuteAsync netcoreapp3.1 1.7μs 1.05ns 3.93ns 0.0127 0 0 952 B
master ExecuteAsync net472 1.78μs 0.352ns 1.36ns 0.145 0 0 915 B
#6549 ExecuteAsync net6.0 1.38μs 0.78ns 2.92ns 0.0131 0 0 952 B
#6549 ExecuteAsync netcoreapp3.1 1.64μs 2.26ns 8.74ns 0.0125 0 0 952 B
#6549 ExecuteAsync net472 1.86μs 0.758ns 2.93ns 0.145 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.32μs 1.85ns 6.68ns 0.0324 0 0 2.31 KB
master SendAsync netcoreapp3.1 5.28μs 1.8ns 6.75ns 0.0369 0 0 2.85 KB
master SendAsync net472 7.32μs 1.43ns 5.36ns 0.495 0 0 3.12 KB
#6549 SendAsync net6.0 4.44μs 1.63ns 6.09ns 0.033 0 0 2.31 KB
#6549 SendAsync netcoreapp3.1 5.24μs 1.73ns 6.24ns 0.0365 0 0 2.85 KB
#6549 SendAsync net472 7.47μs 1.97ns 7.36ns 0.496 0 0 3.12 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.43μs 0.778ns 2.91ns 0.0228 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 2.38μs 3.41ns 12.8ns 0.0219 0 0 1.64 KB
master EnrichedLog net472 2.71μs 1.01ns 3.78ns 0.249 0 0 1.57 KB
#6549 EnrichedLog net6.0 1.47μs 0.939ns 3.39ns 0.0229 0 0 1.64 KB
#6549 EnrichedLog netcoreapp3.1 2.19μs 0.885ns 3.31ns 0.0218 0 0 1.64 KB
#6549 EnrichedLog net472 2.68μs 1.05ns 4.05ns 0.249 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 118μs 141ns 526ns 0 0 0 4.28 KB
master EnrichedLog netcoreapp3.1 123μs 284ns 1.1μs 0.0616 0 0 4.28 KB
master EnrichedLog net472 152μs 188ns 727ns 0.673 0.224 0 4.46 KB
#6549 EnrichedLog net6.0 119μs 178ns 690ns 0 0 0 4.28 KB
#6549 EnrichedLog netcoreapp3.1 122μs 178ns 691ns 0 0 0 4.28 KB
#6549 EnrichedLog net472 152μs 153ns 591ns 0.68 0.227 0 4.46 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.97μs 1.18ns 4.57ns 0.0312 0 0 2.2 KB
master EnrichedLog netcoreapp3.1 4.15μs 1.97ns 7.64ns 0.029 0 0 2.2 KB
master EnrichedLog net472 4.8μs 2.24ns 8.37ns 0.32 0 0 2.02 KB
#6549 EnrichedLog net6.0 2.85μs 1.21ns 4.7ns 0.0312 0 0 2.2 KB
#6549 EnrichedLog netcoreapp3.1 4.09μs 2.23ns 8.64ns 0.0287 0 0 2.2 KB
#6549 EnrichedLog net472 4.85μs 1.45ns 5.6ns 0.319 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.31μs 1.02ns 3.94ns 0.0162 0 0 1.14 KB
master SendReceive netcoreapp3.1 1.82μs 5.64ns 21.9ns 0.0153 0 0 1.14 KB
master SendReceive net472 2.19μs 1.5ns 5.83ns 0.183 0 0 1.16 KB
#6549 SendReceive net6.0 1.34μs 1.15ns 4.47ns 0.0162 0 0 1.14 KB
#6549 SendReceive netcoreapp3.1 1.82μs 0.497ns 1.72ns 0.0155 0 0 1.14 KB
#6549 SendReceive net472 2.16μs 0.813ns 3.15ns 0.183 0 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.67μs 0.993ns 3.84ns 0.0227 0 0 1.6 KB
master EnrichedLog netcoreapp3.1 3.82μs 2.94ns 11.4ns 0.0228 0 0 1.65 KB
master EnrichedLog net472 4.44μs 2.29ns 8.88ns 0.322 0 0 2.04 KB
#6549 EnrichedLog net6.0 2.8μs 0.906ns 3.39ns 0.0224 0 0 1.6 KB
#6549 EnrichedLog netcoreapp3.1 4.04μs 0.774ns 2.9ns 0.0219 0 0 1.65 KB
#6549 EnrichedLog net472 4.43μs 4.4ns 17.1ns 0.324 0 0 2.04 KB
Benchmarks.Trace.SpanBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6549

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑netcoreapp3.1 1.133 835.44 737.18

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 409ns 0.306ns 1.18ns 0.00809 0 0 576 B
master StartFinishSpan netcoreapp3.1 557ns 0.436ns 1.63ns 0.00779 0 0 576 B
master StartFinishSpan net472 702ns 0.404ns 1.51ns 0.0918 0 0 578 B
master StartFinishScope net6.0 518ns 0.289ns 1.08ns 0.0097 0 0 696 B
master StartFinishScope netcoreapp3.1 835ns 0.478ns 1.85ns 0.00919 0 0 696 B
master StartFinishScope net472 860ns 0.687ns 2.66ns 0.104 0 0 658 B
#6549 StartFinishSpan net6.0 396ns 0.201ns 0.78ns 0.00808 0 0 576 B
#6549 StartFinishSpan netcoreapp3.1 552ns 0.337ns 1.31ns 0.00773 0 0 576 B
#6549 StartFinishSpan net472 644ns 0.472ns 1.83ns 0.0916 0 0 578 B
#6549 StartFinishScope net6.0 534ns 0.366ns 1.42ns 0.00975 0 0 696 B
#6549 StartFinishScope netcoreapp3.1 737ns 0.47ns 1.82ns 0.00954 0 0 696 B
#6549 StartFinishScope net472 866ns 0.562ns 2.18ns 0.104 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 673ns 0.349ns 1.35ns 0.00969 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 915ns 0.68ns 2.63ns 0.00923 0 0 696 B
master RunOnMethodBegin net472 1.13μs 0.381ns 1.47ns 0.104 0 0 658 B
#6549 RunOnMethodBegin net6.0 621ns 0.344ns 1.33ns 0.00966 0 0 696 B
#6549 RunOnMethodBegin netcoreapp3.1 899ns 0.675ns 2.61ns 0.0095 0 0 696 B
#6549 RunOnMethodBegin net472 1.02μs 0.958ns 3.71ns 0.105 0 0 658 B

@datadog-ddstaging
Copy link

Datadog Report

Branch report: matang/exception-replay-capturing-improvements
Commit report: fa2c06d
Test service: dd-trace-dotnet

❌ 864 Failed (4 Known Flaky), 247241 Passed, 2986 Skipped, 32h 41m 33.06s Total Time

❌ Failed Tests (864)

This report shows up to 5 failed tests.

  • TestExceptionReplay - Datadog.Trace.Debugger.IntegrationTests.ExceptionReplay.AspNetCore5ExceptionReplayEnabledDynamicInstrumentationDisabled - Details

    Expand for error 
     Results do not match.
 Pending verification:
 AspNetCore5ExceptionReplay.RethrowTest.verified.txt: Empty or does not exist
 AspNetCore5ExceptionReplay.RethrowTest.received.txt
 Iteration 0:
      _dd.di._eh : -1831505458
      _dd.di._er : NotEligible
 Iteration 1:
      _dd.debug.error.0.frame_data.class_name : RethrowTest
      _dd.debug.error.0.frame_data.function : Bar
 ...

  • TestExceptionReplay - Datadog.Trace.Debugger.IntegrationTests.ExceptionReplay.AspNetCore5ExceptionReplayEnabledDynamicInstrumentationDisabled - Details

    Expand for error 
     Results do not match.
 Pending verification:
 AspNetCore5ExceptionReplay.ExceptionCaughtAndRethrownAsInnerTest.verified.txt: Empty or does not exist
 AspNetCore5ExceptionReplay.ExceptionCaughtAndRethrownAsInnerTest.received.txt
 Iteration 0:
      _dd.di._eh : 37630371
      _dd.di._er : NotEligible
 Iteration 1:
      _dd.debug.error.0.frame_data.class_name : ExceptionCaughtAndRethrownAsInnerTest
      _dd.debug.error.0.frame_data.function : Run
 ...

  • TestExceptionReplay - Datadog.Trace.Debugger.IntegrationTests.ExceptionReplay.AspNetCore5ExceptionReplayEnabledDynamicInstrumentationDisabled - Details

    Expand for error 
     Results do not match.
 Pending verification:
 AspNetCore5ExceptionReplay.DeterministicComplexExceptionPropagationTest.verified.txt: Empty or does not exist
 AspNetCore5ExceptionReplay.DeterministicComplexExceptionPropagationTest.received.txt
 Iteration 0:
      _dd.di._eh : 966062974
      _dd.di._er : NotEligible
 Iteration 1:
      _dd.debug.error.0.frame_data.class_name : <SimulateAsyncOperation>d__3
      _dd.debug.error.0.frame_data.function : MoveNext
 ...

  • TestExceptionReplay - Datadog.Trace.Debugger.IntegrationTests.ExceptionReplay.AspNetCore5ExceptionReplayEnabledDynamicInstrumentationDisabled - Details

    Expand for error 
     Results do not match.
 Differences:
 Received: AspNetCore5ExceptionReplay.ExceptionWithNonSupportedFramesTest.received.txt
 Verified: AspNetCore5ExceptionReplay.ExceptionWithNonSupportedFramesTest.verified.txt
 Received Content:
 Iteration 0:
      _dd.di._eh : 99734833
      _dd.di._er : NotEligible
 Iteration 1:
      _dd.debug.error.0.frame_data.class_name : ExceptionWithNonSupportedFramesTest
 ...

  • TestExceptionReplay - Datadog.Trace.Debugger.IntegrationTests.ExceptionReplay.AspNetCore5ExceptionReplayEnabledDynamicInstrumentationDisabled - Details

    Expand for error 
     Results do not match.
 Differences:
 Received: AspNetCore5ExceptionReplay.RecursiveExceptionTest.received.txt
 Verified: AspNetCore5ExceptionReplay.RecursiveExceptionTest.verified.txt
 Received Content:
 Iteration 0:
      _dd.di._eh : -1983679601
      _dd.di._er : NotEligible
 Iteration 1:
      _dd.debug.error.0.frame_data.class_name : <Recursive>d__1
 ...

@andrewlock
Copy link
Member

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6549) (11.079M)   : 0, 11079113
    master (11.032M)   : 0, 11032000
    benchmarks/2.9.0 (11.045M)   : 0, 11045405

    section Automatic
    This PR (6549) (7.217M)   : 0, 7217204
    master (7.407M)   : 0, 7406710
    benchmarks/2.9.0 (7.885M)   : 0, 7885346

    section Trace stats
    master (7.538M)   : 0, 7537791

    section Manual
    master (11.239M)   : 0, 11239358

    section Manual + Automatic
    This PR (6549) (6.697M)   : 0, 6696650
    master (6.808M)   : 0, 6807779

    section DD_TRACE_ENABLED=0
    master (10.211M)   : 0, 10211123
Loading 
gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6549) (9.834M)   : 0, 9833649
    master (9.841M)   : 0, 9840746
    benchmarks/2.9.0 (9.586M)   : 0, 9586476

    section Automatic
    This PR (6549) (6.524M)   : 0, 6523904
    master (6.548M)   : 0, 6547783

    section Trace stats
    master (6.702M)   : 0, 6702058

    section Manual
    master (9.698M)   : 0, 9698446

    section Manual + Automatic
    This PR (6549) (6.030M)   : 0, 6030314
    master (5.807M)   : 0, 5807486

    section DD_TRACE_ENABLED=0
    master (9.035M)   : 0, 9034722
Loading 
gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6549) (10.047M)   : 0, 10046718

    section Automatic
    This PR (6549) (6.584M)   : 0, 6583986

    section Manual + Automatic
    This PR (6549) (6.164M)   : 0, 6164244
Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GreenMatan @andrewlock